Decompression Threads #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting is a mess; I'm on my mac and I don't have my rustfmt updated... Fixing soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forcing context-switches with block_in_place when the
tokio-runtimefeature was enabled, we spawn a dedicated thread for the decompression and use std lib to send data over to the dedicated thread, handle decompression there and send the result back via a future oneshot channel.This channel can be polled in a nested context from the ZlibStream implementation.
This PR is a replacement for the
tokio-runtimefeature in it's functionality, but the tokio-runtime feature is still available to use tokio::spawn_blocking for blocking tasks, instead of starting an own thread.To enable the features from this PR, enable the
threadfeature flag.